Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 Release Candidate #1112

Merged
merged 5 commits into from
Nov 1, 2024
Merged

2024 Release Candidate #1112

merged 5 commits into from
Nov 1, 2024

Conversation

jmccrae
Copy link
Member

@jmccrae jmccrae commented Oct 11, 2024

When this branch is merged, it will be tagged as the 2024 release

"WordNet" with a capital N is a trademark of Princeton University, to
avoid any issues the project will now on use a lowercase "n"
@jmccrae jmccrae added this to the 2024 Release milestone Oct 11, 2024
@jmccrae
Copy link
Member Author

jmccrae commented Oct 21, 2024

@1313ou @fcbond @goodmami

2024 Release Candidate is ready. Please let me know of any issues by the end of the week.

@goodmami
Copy link
Member

@jmccrae I generated the xml file with scripts/from_yaml.py. First, I noticed that the generated file uses the WN-LMF-relaxed-1.3.dtd schema instead of WN-LMF-1.3.dtd because of the second True argument in this line:

wn.to_xml(outp, True)

thus, part=True here:

def to_xml(self, xml_file, part=False):
xml_file.write("""<?xml version="1.0" encoding="UTF-8"?>\n""")
if part:
xml_file.write(
"""<!DOCTYPE LexicalResource SYSTEM "http://globalwordnet.github.io/schemas/WN-LMF-relaxed-1.3.dtd">\n""")
else:
xml_file.write(
"""<!DOCTYPE LexicalResource SYSTEM "http://globalwordnet.github.io/schemas/WN-LMF-1.3.dtd">\n""")

Is there a reason to use the -relaxed schema, or should it be the normal one?

And, tangentially, it looks like the -relaxed schema may not be updated as it does not have the xml:space attribute?

Once I stopped Wn from rejecting the relaxed schema in the doctype declaration, I didn't have any issues adding it to the database and running some simple queries. I haven't yet done more extensive testing beyond that. So, for now, the main issue is with the doctype schema.

@jmccrae
Copy link
Member Author

jmccrae commented Oct 29, 2024

The 'relaxed' scheme was used to allow multiple small XML files, which would be merged later. This was how we worked with the wordnet before we adopted YAML in #664, it should not be generated anymore.

@jmccrae jmccrae merged commit faaef93 into main Nov 1, 2024
2 checks passed
@jmccrae jmccrae deleted the 2024-release-candidate branch November 1, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants