Fix A3 SSType #643
Open
Fix A3 SSType #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagolotufo
reviewed
Dec 3, 2024
| @@ -126,16 +126,16 @@ func InitDatabase() error { | |||
|
|
|||
| dbConn, err := OpenDBConnection() | |||
| if err != nil { | |||
| errOpenDBConnection := fmt.Sprintf("OpenDBConnection error: %s", err) | |||
| errOpenDBConnection := ("OpenDBConnection error: %s" + err) | |||
There was a problem hiding this comment.
Why did you make this modification?
There was a problem hiding this comment.
It has nothing to do with the vulnerability, I just saw that it is a string formatting practice in Go
thiagolotufo
reviewed
Dec 3, 2024
| _, err = dbConn.Exec(queryCreate) | ||
| if err != nil { | ||
| errInitDB := fmt.Sprintf("InitDatabase error: %s", err) | ||
| errInitDB := ("InitDatabase error: %s" + err) |
There was a problem hiding this comment.
The same question as line 129.
There was a problem hiding this comment.
the same response for line 129
thiagolotufo
reviewed
Dec 3, 2024
There was a problem hiding this comment.
This commit is about another application. Could you split this PR into three others?
There was a problem hiding this comment.
I did the labs in sequence and I think I didn't start the branch at the right time for SSType, can you help me fix this? Should I delete the PRs and redo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution refers to which of the apps?
A3 - SSType
What did you do to mitigate the vulnerability?
Replaced 'NAMEHERE' with '{{ name }}' in the template and used Tornado's secure rendering to handle user input safely.
Did you test your changes? What commands did you run?
I tested the changes by reproducing the attack narrative.