Add ConnectorTable.extend() method#1021
Merged
sirosen merged 1 commit intoglobus:mainfrom Mar 4, 2025
Merged
Conversation
This method allows ConnectorTable consumers to extend the class with an additional connector (or, if they chain calls, multiple connectors). The new connector is written into the new subclass as a part of its `_connectors` tuple and as an attribute. The base ConnectorTable class is left unmodified, meaning that callers who extend the table cannot conflict. A usage example is provided in the docstring for `extend()` to instruct users on proper usage.
sirosen
force-pushed
the
connector-table-extend
branch
from
28b65c8 to
6f6c331
Compare
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
m1yag1
approved these changes
Feb 21, 2025
Contributor
m1yag1
left a comment
m1yag1
left a comment
There was a problem hiding this comment.
Only one minor thing I saw with the changelog. Other than that, it looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method allows ConnectorTable consumers to extend the class with an additional connector (or, if they chain calls, multiple connectors). The new connector is written into the new subclass as a part of its
_connectorstuple and as an attribute.The base ConnectorTable class is left unmodified, meaning that callers who extend the table cannot conflict.
The motivation for this work is for usages in primarily internal applications like the GCS CLI, where new connectors are sometimes supported for testing before they are generally available. Additionally, users beta testing such connectors may want SDK support.
At time of writing, there is at least one internal connector under development which cannot be added to the SDK yet.
📚 Documentation preview 📚: https://globus-sdk-python--1021.org.readthedocs.build/en/1021/