Document auto-login disabling#1127
Merged
derek-globus merged 1 commit intoglobus:mainfrom Jan 14, 2025
Merged
Conversation
derek-globus
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
kurtmckee,
m1yag1 and
sirosen
as code owners
sirosen
approved these changes
Jan 14, 2025
Member
sirosen
left a comment
sirosen
left a comment
There was a problem hiding this comment.
I think those infix type declarations in ivar blocks for Sphinx might not be needed, since sphinx can read annotations. But let me look at fixing that after this merges, so that we can have the doc content itself updated.
Member
|
FWIW: I was wrong. autodoc_typehints doesn't support loading the annotations off of dataclass fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GlobusAppConfig.token_validation_error_handlerwas set to None (or explain that it could be set to None). Added that explanation.📚 Documentation preview 📚: https://globus-sdk-python--1127.org.readthedocs.build/en/1127/