Custom field translations

[cconard96]

Checklist before requesting a review

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.

Description

Allow translating custom field labels

[cconard96]

Waiting for functional/technical review to ensure this feature is finalized before adding tests.

[orthagh]

Ok, I was curious about where the translation system will be displayed.
Re-using the existing tab (translations) is clever in fact.

I suggest the following changes:

• remove the "Custom field translation"
• Always display the "Field" dropdown
• include the "asset name" option in this dropdown
• add a helper on the top of the modal explaining you can translate either the asset name or custom fields.
• merge the 2 tables into the second one, translation entry for the asset name displayed in the single list, and differentiate again by filling the "Field" column.

There is not so much work remaining (I don't know about tests) and this pr could be integrated very soon.

[cedric-anne]

Apart from the few minor comments I made, it seems to me to be OK from the technical point of view.

A more generic system for the translation storage may be introduced by #18223 , but migrating to it, if it is relevant, could be done later and should not be consider as a blocker for the current PR.

[orthagh]

It's still ok for me from a technical pov.
what do you prefer to merge first @cconard96: this pr or the one for reordering fields ?

[cconard96]

It's still ok for me from a technical pov. what do you prefer to merge first @cconard96: this pr or the one for reordering fields ?

I don't think it matters. This one will probably be approved before the custom field reordering one.

[trasher]

I guess tests should be added, at least for new PHP classes/methods.

[trasher]

Is this one still WIP? (if not, please remove label)