Skip to content

Search for forms and faq articles on home page #18239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2024
Merged

Search for forms and faq articles on home page #18239

merged 3 commits into from
Nov 25, 2024

Conversation

AdrienClairembault
Copy link
Contributor

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.

Description

Allow user to search for forms and faq articles on home page.

Screenshots (if appropriate):

image

@AdrienClairembault AdrienClairembault self-assigned this Nov 6, 2024
@AdrienClairembault AdrienClairembault marked this pull request as ready for review November 6, 2024 12:45
@cedric-anne cedric-anne requested a review from orthagh November 21, 2024 09:15
cedric-anne
cedric-anne reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if there is 50 FAQ entries and 10 forms matching the searched term ?

@orthagh
Copy link
Contributor

orthagh commented Nov 21, 2024

A question also, how behave the description if (very) long ?

@AdrienClairembault
Copy link
Contributor Author

What will happen if there is 50 FAQ entries and 10 forms matching the searched term ?

I want to add some kind of infinite scroll (or similar solutions) later.
For now we can put an hardcoded limit to 20.

@AdrienClairembault
Copy link
Contributor Author

A question also, how behave the description if (very) long ?

There is an ellipsis:

image

orthagh
orthagh approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@orthagh orthagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the limit, yes. Anyway OK for me.

@cedric-anne cedric-anne added this to the 11.0.0 milestone Nov 25, 2024
@cedric-anne cedric-anne merged commit 426fa05 into glpi-project:main Nov 25, 2024
7 of 8 checks passed
@AdrienClairembault AdrienClairembault deleted the feature/home-search branch November 25, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orthagh orthagh orthagh approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

Assignees

@AdrienClairembault AdrienClairembault

Labels
Forms
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrienClairembault @orthagh @cedric-anne