Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify negated search operations #18256

Conversation

cedric-anne
Copy link
Member

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.

Description

It may fix #18251, but it may also completely break existing tests.

@cedric-anne cedric-anne self-assigned this Nov 7, 2024
@trasher
Copy link
Contributor

trasher commented Nov 7, 2024

As discussed on our internal channel, this is the kind of issue that has existed for years... This would need to add many, many tests (but I do not have any idea which ones).

We also know the whole search mechanisms should be rewritten... There probably are issues that cannot be solved until this is done.

I'm not sure I'll accept that kind of change on bugfixes version anyway.

@cedric-anne
Copy link
Member Author

cedric-anne commented Nov 7, 2024

As discussed on our internal channel, this is the kind of issue that has existed for years... This would need to add many, many tests (but I do not have any idea which ones).

We also know the whole search mechanisms should be rewritten... There probably are issues that cannot be solved until this is done.

I'm not sure I'll accept that kind of change on bugfixes version anyway.

I will keep this PR as a draft for now. It is not a priority, but I would like, at least, to add many tests, to prevent future regressions. We could then merge the tests in the bugfixes version, and the refacored code in the next major version.

@trasher
Copy link
Contributor

trasher commented Nov 7, 2024

Correct tests would fail on bugfixes version :D Anyway, that's not a priority, we'll see.

@cedric-anne cedric-anne deleted the 10.0/fix-not-search branch January 29, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants