-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rely on controller for inventory #18312
Rely on controller for inventory #18312
Conversation
ping @cedric-anne, I need a "pre-review" for this one. |
You can add a
There is no reason for it to be used in production. I guess it is mostly used to easilly process inventory files when debugging an issue. |
bee3568
to
6436d7e
Compare
I do not understand why tests fails with unsupported method while GET and POST are both explicitly allowed on the route. |
Inventory for cli has been moved to tool/inventory.php Use constant instead of hardcoded string
a7799f9
to
9097ac3
Compare
Co-authored-by: Cédric Anne <[email protected]>
Add test on prolog request for all possibles calls (/, /Inventory and front/inventory.php)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK.
Refused equipments conversion should maybe use their own route, I did not test this case yet (this may be done in another PR, will see).