Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forms): Horizontal layout #18354

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ccailly
Copy link
Member

@ccailly ccailly commented Nov 20, 2024

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

Added the possibility of grouping up to 4 questions (or comments) in a horizontal layout.

Screenshots (if appropriate):

Capture.video.du.20-11-2024.14.15.52.webm

@ccailly ccailly self-assigned this Nov 20, 2024
@ccailly ccailly added the Forms label Nov 20, 2024
@ccailly ccailly added this to the 11.0.0 milestone Nov 20, 2024
@ccailly
Copy link
Member Author

ccailly commented Nov 20, 2024

Horizontal layout behavior on form rendering.

Capture.video.du.20-11-2024.16.24.18.webm

@ccailly ccailly marked this pull request as ready for review November 21, 2024 08:42
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems impossible to drag a question between two horizontal layouts or at the top of the form if the first question use the horizontal layout:

image

@AdrienClairembault
Copy link
Contributor

When dragging a question from a horizontal row, it can't be added next to a a question that is not on a row:

image

It only work with questions that are not from a row (you can see the extra space that allow the question to be inserted):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants