Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate mail tests #18393

Merged
merged 10 commits into from
Nov 28, 2024
Merged

Conversation

trasher
Copy link
Contributor

@trasher trasher commented Nov 27, 2024

No description provided.

@trasher
Copy link
Contributor Author

trasher commented Nov 27, 2024

Currently fails on a test using a provider... I wonder if the eval() used in this provider is not the cause; I cannot test locally.

@trasher
Copy link
Contributor Author

trasher commented Nov 27, 2024

Currently fails on a test using a provider... I wonder if the eval() used in this provider is not the cause; I cannot test locally.

I've replaced eval with real classes from files, tests still fails... I guess this is another gap between atoum and phpunit, but I've no idea what's wrong here.

@cedric-anne
Copy link
Member

Currently fails on a test using a provider... I wonder if the eval() used in this provider is not the cause; I cannot test locally.

I've replaced eval with real classes from files, tests still fails... I guess this is another gap between atoum and phpunit, but I've no idea what's wrong here.

The plugin was not marked as activated/loaded, and therefore the corresponding hooks were not executed due to

glpi/src/Plugin.php

Lines 1757 to 1759 in 956702e

if (!Plugin::isPluginActive($plugin_key)) {
continue;
}

@trasher
Copy link
Contributor Author

trasher commented Nov 28, 2024

The plugin was not marked as activated/loaded, and therefore the corresponding hooks were not executed due to

OK, strange it did not break before then :)

@trasher trasher marked this pull request as ready for review November 28, 2024 07:09
@cedric-anne
Copy link
Member

The plugin was not marked as activated/loaded, and therefore the corresponding hooks were not executed due to

OK, strange it did not break before then :)

Plugins loading state is stored in static variables, this is probably the problem here.

@cedric-anne cedric-anne merged commit 7c69453 into glpi-project:10.0/bugfixes Nov 28, 2024
7 checks passed
@trasher trasher deleted the migrate-mail-tests branch November 28, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants