Skip to content

Conversation

AdrienClairembault
Copy link
Contributor

@AdrienClairembault AdrienClairembault commented May 20, 2025

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.

Description

Replace #18927 with only one test (others needs to be reworked since they have been updated on cypress in the meantime - will be done on dedicated PRs to keep this one light).

@AdrienClairembault AdrienClairembault self-assigned this May 20, 2025
@AdrienClairembault AdrienClairembault force-pushed the playwright2 branch 8 times, most recently from e17c35f to 56d9d00 Compare May 21, 2025 13:35
@AdrienClairembault
Copy link
Contributor Author

AdrienClairembault commented May 21, 2025

This setup is nearly complete and could be merged right now IMO, which will allow me to get started on migrating existing tests (and adding an install test as we discussed today).

Things that are missing and could be added in a followup PR:

  • Use a dedicated "e2e" environment different from "testing" (more convenient for running tests locally as they won't conflict/pollute the phpunit database. We have a good idea on how to do this with @cedric-anne and we can probably do it next week). -> done in 8bd6ad5.
  • Use our own runner for better performances and multi-threading (not relevant yet as only one test exist, can be delayed until more tests are migrated. POC have been done on possible runners already, just need some more tests with our own machines to limit costs).

@AdrienClairembault AdrienClairembault marked this pull request as ready for review May 21, 2025 13:42
@trasher
Copy link
Contributor

trasher commented May 22, 2025

Trying to run locally, I got the following fail:
image

@AdrienClairembault
Copy link
Contributor Author

AdrienClairembault commented May 26, 2025

Can you retry with the latest changes (and generate a trace (npx playwright test --trace=on) and send it to me if it still fails) ?

@AdrienClairembault AdrienClairembault marked this pull request as draft May 27, 2025 11:45
@AdrienClairembault AdrienClairembault force-pushed the playwright2 branch 5 times, most recently from b992b7a to 4d5f8d0 Compare May 28, 2025 07:42
@trasher
Copy link
Contributor

trasher commented Jun 2, 2025

WIth lastest changes, I no longer can run tests:

Can you retry with the latest changes (and generate a trace (npx playwright test --trace=on) and send it to me if it still fails) ?

My local setup is now broken. I'm not going to spend more time on that; goal is not to run all that locally.

@AdrienClairembault AdrienClairembault force-pushed the playwright2 branch 3 times, most recently from 847920d to 1f6d4ec Compare July 2, 2025 14:45
@AdrienClairembault
Copy link
Contributor Author

AdrienClairembault commented Jul 7, 2025

@cedric-anne the recent changes you made to the githubactions-php-apache ci image prevent me from running the playwright tests on them.

Indeed, you forced the testing env in the virtual env which mean we can't run playwright on the e2e_testing env.
We need to either:

  • Rollback this change (find another fix if possible, I do not know why you needed this)
  • Change githubactions-php-apache to expose another port with the e2e_testing env, like we did for the dev image.

Edit: done, see glpi-project/docker-images@1b77895.

@AdrienClairembault AdrienClairembault marked this pull request as ready for review July 7, 2025 14:22
@cedric-anne cedric-anne added this to the 11.0.0 milestone Jul 21, 2025
@cedric-anne cedric-anne changed the base branch from main to 11.0/bugfixes July 29, 2025 13:16
@cedric-anne cedric-anne mentioned this pull request Jul 30, 2025
@trasher trasher removed this from the 11.0.0 milestone Sep 30, 2025
@AdrienClairembault AdrienClairembault marked this pull request as draft October 3, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants