Deprecate unsafe method execution in dropdown controller #21204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trasher
approved these changes
Oct 1, 2025
AdrienClairembault
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Building the name of a method to execute using request inputs is not safe. There is currently no security issue with this, in both GLPI and in public plugins downloadable from the plugin catalog, but it is still preferable to deprecate this way to do and remove it in a future GLPI version.
Also, we do not use it in GLPI. It was used before #17203, but if we restore a similar controller action in #21180 to fix the corresponding form, the best way would be to create a dedicated controller that extends the
DropdownControllerto implement a specific action.