Skip to content

Commit

Permalink
Merge pull request #39 from astrofrog/fix-ci
Browse files Browse the repository at this point in the history
Comment out failing build (due to Qt issues)
  • Loading branch information
astrofrog authored Jul 19, 2024
2 parents 27dc55f + a9a5e79 commit 00afe63
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci_workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
# Test some configurations on Windows
- windows: py38-test-pyqt514
- windows: py39-test-pyqt515
- windows: py310-test-pyqt63
# - windows: py310-test-pyqt63
- windows: py38-test-pyside515
- windows: py310-test-pyside63
Expand Down
10 changes: 5 additions & 5 deletions echo/tests/test_selection.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,13 @@ def test_callbacks(self):
self.state.add_callback('a', func)

self.a.set_choices(self.state, [1, 2, 3])
assert func.called_once_with(1)
func.assert_called_with(1)

self.state.a = 2
assert func.called_once_with(2)
func.assert_called_with(2)

self.a.set_choices(self.state, [4, 5, 6])
assert func.called_once_with(4)
func.assert_called_with(4)

def test_choice_separator(self):

Expand All @@ -128,13 +128,13 @@ def test_delay(self):
with delay_callback(self.state, 'a'):
self.a.set_choices(self.state, [4, 5, 6])
assert func.call_count == 0
assert func.called_once_with(4)
func.assert_called_once_with(4)
func.reset_mock()

# Check that the callback gets called even if only the choices
# but not the selection are changed in a delay block
with delay_callback(self.state, 'a'):
self.a.set_choices(self.state, [1, 2, 4])
assert func.call_count == 0
assert func.called_once_with(4)
func.assert_called_once_with(4)
func.reset_mock()

0 comments on commit 00afe63

Please sign in to comment.