-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated call to pkg_resources #36
Remove deprecated call to pkg_resources #36
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 96.65% 96.74% +0.09%
==========================================
Files 17 17
Lines 2182 2182
==========================================
+ Hits 2109 2111 +2
+ Misses 73 71 -2
☔ View full report in Codecov by Sentry. |
I'm not sure exactly what's going on what that remaining test failure. |
I recall seeing that elsewhere with an older Windows env, obviously messing up the volume label in the default |
Thanks! We've already dropped Python 3.7 for glue-core so I think we can just require >=3.8 here now? |
Was wondering if it was required for pyqt510, but 5.10.1 seems to have wheels for 3.8 already. |
Looks like I pushed just as you were commenting here. I removed the py37 tests, but do you want one back for pyqt510? The main glue package requires >=5.14, so we could just drop some older versions... |
Was just wondering if there was a specific reason to test the older versions here, but otherwise yes, keeping them in sync with glue-core (which underwent a major cleanup last year) probably makes sense. |
Keeping in sync with glue-core is fine! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions for py311 test envs, will still need to be added to tox.ini
– @jfoster17 we should re-run the CI with these, and then this should finally be ready to go.
Co-authored-by: Derek Homeier <[email protected]>
Co-authored-by: Derek Homeier <[email protected]>
Co-authored-by: Derek Homeier <[email protected]>
Thanks, everything looking great! I will probably squash for the merge. |
Okay, please do squash. |
Alternatively, if you could squash just the last 4 commits into one and force-push, should be good as well. But either way is fine. |
Remove explicit calls to pkg_resources
Description
Sort of following the process in glue-viz/glue#2365, this updates echo to not depend on the deprecated pkg_resources API, at the cost of requiring
importlib_metadata
for older versions of Python (but glue installations will have this dependency anyway with the above-referenced change).