Merge pull request #395 from Carifio24/fix-adjusting-min-max

Fix issues with adjusting min/max values for size and cmap
glue-viz · Aug 31, 2023 · 83aeb3a · 83aeb3a
2 parents 33afdfb + 4d611ee
commit 83aeb3a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/glue_jupyter/common/state_widgets/layer_scatter.vue b/glue_jupyter/common/state_widgets/layer_scatter.vue
@@ -9,10 +9,10 @@
                 <v-select label="attribute" :items="cmap_att_items" v-model="cmap_att_selected" hide-details />
             </div>
             <div>
-                <v-text-field label="min" v-model="glue_state.cmap_vmin" hide-details></v-text-field>
+                <glue-float-field label="min" :value.sync="glue_state.cmap_vmin" />
             </div>
             <div>
-                <v-text-field label="max" v-model="glue_state.cmap_vmax" hide-details></v-text-field>
+                <glue-float-field label="max" :value.sync="glue_state.cmap_vmax" />
             </div>
             <div>
                 <v-select label="colormap" :items="cmap_items" :value="glue_state.cmap" @change="set_colormap" hide-details/>
@@ -39,10 +39,10 @@
                     <v-select label="attribute" :items="size_att_items" v-model="size_att_selected" hide-details />
                 </div>
                 <div>
-                    <v-text-field label="min" v-model="glue_state.size_vmin" hide-details></v-text-field>
+                    <glue-float-field label="min" :value.sync="glue_state.size_vmin" />
                 </div>
                 <div>
-                    <v-text-field label="max" v-model="glue_state.size_vmax" hide-details></v-text-field>
+                    <glue-float-field label="max" :value.sync="glue_state.size_vmax" />
                 </div>
             </template>
             <template v-if="glue_state.density_map">

diff --git a/glue_jupyter/state_traitlets_helpers.py b/glue_jupyter/state_traitlets_helpers.py
@@ -72,7 +72,7 @@ def update_state_from_dict(state, changes):
                                 callback_dict[k] = changes[name][k]
             else:
                 if changes[name] != MAGIC_IGNORE and getattr(state, name) != changes[name]:
-                    if 'cmap' in name:
+                    if name == 'cmap':
                         if changes[name] != state.cmap.name:
                             setattr(state, name, get_cmap(changes[name]))
                     else: