Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vectors in the bqplot viewers, and vector options in the layer state panel #458

Merged
merged 12 commits into from
Mar 13, 2025

Conversation

CyclingNinja
Copy link
Contributor

@CyclingNinja CyclingNinja commented Aug 7, 2024

Adding functionality for vector scaling and origins in layer state menu

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 80.48780% with 16 lines in your changes missing coverage. Please review.

Project coverage is 85.93%. Comparing base (ee93916) to head (cf10b09).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
glue_jupyter/bqplot/scatter/layer_artist.py 78.94% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   86.03%   85.93%   -0.11%     
==========================================
  Files          91       91              
  Lines        5269     5345      +76     
==========================================
+ Hits         4533     4593      +60     
- Misses        736      752      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhomeier dhomeier added enhancement New feature or request vuetify labels Sep 3, 2024
@CyclingNinja CyclingNinja force-pushed the scatter_options branch 3 times, most recently from 807289e to 1763c5a Compare January 10, 2025 14:33
@dhomeier
Copy link
Contributor

visual test failure is related to solara fix in #475.
Might want to use some sort of pre-commit setup ;-)

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! I just tried it out, and just have a couple of small comments below.

I think we should probably add a visual test for this - there are a few other existing visual tests, maybe you can copy one of those and try and make an example that exercises both the dashed lines and the vectors in one plot?


# maybe i need vector lines here too?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you clarify this comment? can this be removed?

@astrofrog astrofrog changed the title Scatter options Add support for vectors in the bqplot viewers, and vector options in the layer state panel Feb 28, 2025
@CyclingNinja CyclingNinja force-pushed the scatter_options branch 3 times, most recently from 9197b8f to 629cbe9 Compare March 5, 2025 15:16
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's merge this and we can do a visual test in a separate PR

@astrofrog astrofrog merged commit a7101a4 into glue-viz:main Mar 13, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vuetify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants