-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for vectors in the bqplot viewers, and vector options in the layer state panel #458
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
==========================================
- Coverage 86.03% 85.93% -0.11%
==========================================
Files 91 91
Lines 5269 5345 +76
==========================================
+ Hits 4533 4593 +60
- Misses 736 752 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
807289e
to
1763c5a
Compare
0dd9d0c
to
8a14e80
Compare
visual test failure is related to solara fix in #475. |
2df5eb1
to
bad0aac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! I just tried it out, and just have a couple of small comments below.
I think we should probably add a visual test for this - there are a few other existing visual tests, maybe you can copy one of those and try and make an example that exercises both the dashed lines and the vectors in one plot?
|
||
# maybe i need vector lines here too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you clarify this comment? can this be removed?
Clean up for PR
d0d5279
to
f767f32
Compare
9197b8f
to
629cbe9
Compare
629cbe9
to
cf10b09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, let's merge this and we can do a visual test in a separate PR
Adding functionality for vector scaling and origins in layer state menu