Initialize all trace metadata IDs #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up other traces (like those added by tools).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the viewer layer artists to initialize all of the fields used for trace UUIDs when the layer artist is created. Currently these values are left as
Noneuntil the relevant trace type is created. This causes a problem for any tools that create traces on the figure that don't have ametafield set: trace-getting methods such as e.g._get_linesin the scatter layer artist can then pick up these traces in their results if_lines_idis stillNone. While all of the traces inglue-plotlyhave use themetafield of the trace, it's obviously better to make things more robust here rather than demand that any possible tool obey the same pattern.