Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow gaps between histogram bars and fix axis labels #72

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

Carifio24
Copy link
Member

This PR adds the ability for the histogram viewer to display adjustable-width gaps between its bars. Whether to use gaps is determined by the viewer state's gaps attribute, while the gap fraction (ranging from 0 to 1) is set by gap_fraction. This is implemented via the Plotly figure's bargap and is thus a viewer-level property.

This PR also fixes a small bug where the axis title data was overwritten, rather than updated, when changing the label.

@Carifio24 Carifio24 added bug Something isn't working enhancement New feature or request viewers labels Jun 20, 2024
@Carifio24 Carifio24 force-pushed the histogram-viewer-gaps branch 4 times, most recently from f8a776a to 9f8d543 Compare June 23, 2024 23:25
@Carifio24 Carifio24 merged commit 62385f3 into glue-viz:main Jun 24, 2024
33 checks passed
@Carifio24 Carifio24 changed the title Histogram viewer gaps and axis label fix Allow gaps between histogram bars and fix axis labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request viewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant