Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI issues and fix colormap validation with numpy 2 #75

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Fix CI issues and fix colormap validation with numpy 2 #75

merged 2 commits into from
Jun 24, 2024

Conversation

Carifio24
Copy link
Member

This PR resolves #74, as well as fix another test issue with creating image exports:

  • As mentioned in Certain CI runs are hanging  #74, the CI issue there is related to the bug fixed by Update ptp call for numpy 2 glue-qt#19. This PR works around this by skipping the dendrogram tests if numpy>=2.0
  • This PR also fixes an issue that popped up with the Plotly's colormap validator. This is also related to numpy as it involved using numpy float64s inside of format strings.

@Carifio24 Carifio24 merged commit b9fc9f0 into glue-viz:main Jun 24, 2024
33 checks passed
@Carifio24 Carifio24 added no-changelog-entry-needed Skipped in automatic changelog generation CI bug Something isn't working and removed no-changelog-entry-needed Skipped in automatic changelog generation labels Jun 25, 2024
@Carifio24 Carifio24 changed the title Fix CI issues Fix CI issues and fix colormap validation with numpy 2 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certain CI runs are hanging
1 participant
@Carifio24