Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tables for incompatible subsets #12

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

jfoster17
Copy link
Member

Catch IncompatibleAttributeError for subset-only tables and show newly-valid subsets

Description

There were a few state problems with tables and incompatible subsets. This fixes the following two issues:

  1. A table without the underlying full data layer visible (i.e. just one or more subsets) would generate an uncaught IncompatibleAttributeError when any of the visible subsets became invalid (i.e. because they were no longer subsets on the tabular dataset.
  2. When a subset was disabled for a table viewer (because it was incompatible), later redefining that same subset on the tabular dataset did not re-enable the subset layer in the viewer, which makes it look as if the subset creation did not work.

@astrofrog astrofrog merged commit 37dd079 into glue-viz:main Jul 19, 2024
30 of 36 checks passed
astrofrog added a commit to astrofrog/glue-qt that referenced this pull request Aug 16, 2024
…s-in-table

Improve tables for incompatible subsets
@astrofrog astrofrog added the bug Something isn't working label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants