Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for glue-qt #98

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Updates for glue-qt #98

merged 6 commits into from
Aug 18, 2023

Conversation

Carifio24
Copy link
Member

@Carifio24 Carifio24 commented Aug 12, 2023

This PR will update glue-wwt to be compatible with the new glue-qt package, once we're ready for that (see glue-viz/glue#2431). If the locations of things change, I will update here.

To do:

  • Update package setup

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8c7eeda) 68.04% compared to head (2d1d707) 68.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   68.04%   68.04%           
=======================================
  Files          18       18           
  Lines         992      992           
=======================================
  Hits          675      675           
  Misses        317      317           
Files Changed Coverage Δ
glue_wwt/viewer/image_style_editor.py 63.63% <100.00%> (ø)
glue_wwt/viewer/options_widget.py 96.92% <100.00%> (ø)
glue_wwt/viewer/qt_data_viewer.py 94.11% <100.00%> (ø)
glue_wwt/viewer/table_style_editor.py 81.81% <100.00%> (ø)
glue_wwt/viewer/tests/test_wwt_widget.py 97.47% <100.00%> (ø)
glue_wwt/viewer/tools.py 50.94% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astrofrog
Copy link
Member

I've now released glue-qt v0.1.0 so you should be able to add that package as a dependency here (at least for the testing - we probably don't want it to be a compulsory runtime dependency in case glue-wwt is used in jupyter for instance).

@Carifio24 Carifio24 marked this pull request as ready for review August 15, 2023 19:01
@Carifio24
Copy link
Member Author

@astrofrog I've added glue-qt as a dependency for the test and qt install options (and also moved qtpy). I've also bumped the minimum Python version from 3.7 -> 3.8 to match glue-core, and swapped out the 3.7 CI for 3.11 as well. Let me know if you see any issues with those changes.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Feel free to merge once you are happy with it

@Carifio24 Carifio24 merged commit 0608958 into glue-viz:main Aug 18, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants