fixes #128 - throw away redundant shenanigans with classpath & module… #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, it should no longer be needed after #181, and plugin version 1.0.21-SNAPSHOT (from https://oss.sonatype.org/content/repositories/snapshots). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #128 and #157.
--module-path has already configured by org.openjfx:javafx-plugin which is used side by side with this plugin.
There is no need to spoil this configuration with this redundant work.
As reported in issues - nativeRunAgent doesn't work at all and this modification fixes it.
Tested with Gradle 7.4.2