Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support application.mainClass #183

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

samypr100
Copy link
Contributor

Uses non-deprecated application.mainClass name, falls back to deprecated mainClassName if not found.

Also updated getClassPathFromSourceSets to use similar approach, which leads to improved typing and avoids null scenarios.

Closes #127

…ed convention and lazy plugin loading to get source main sets
Copy link
Collaborator

@jperedadnr jperedadnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some comments.

@abhinayagarwal abhinayagarwal merged commit d3e0397 into gluonhq:master Jul 14, 2024
1 check passed
@samypr100 samypr100 deleted the application-plugin-compat branch July 14, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mainClassName is depracated
3 participants