Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for table navigation with up and down arrows #280

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

jperedadnr
Copy link
Collaborator

Fixes #279

@abhinayagarwal
Copy link
Collaborator

  • In a 2x2 table, if the cursor is in [1,1] pressing DOWN will take use to [2,1] and vice-versa on pressing UP. The same fails if the cursor is on the 2 column.
  • If the table is longer than the viewport, a scrollbar is added to the RTA. Pressing DOWN then scrolls the scollbar instead of navigating throw the rows.

@abhinayagarwal
Copy link
Collaborator

Disregard my last comment, I had an old snapshot dependency.

Tested again and all looks good. Just one minor comment: when we go down, the cursor always is on the start of the text and when we go up it is always on the end of the text. Do we want to streamline the behavior or is this intended?

@jperedadnr
Copy link
Collaborator Author

It is intended. I've taken some inspiration from the Notes app (macOS).

@jperedadnr jperedadnr merged commit 6f13f4f into gluonhq:main Aug 2, 2023
1 check passed
@jperedadnr jperedadnr deleted the 279-tableupdown branch August 2, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table navigation with up/down arrows
2 participants