Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API for decoration at caret and paragraph #301

Merged
merged 2 commits into from
Jan 17, 2024
Merged

API for decoration at caret and paragraph #301

merged 2 commits into from
Jan 17, 2024

Conversation

jperedadnr
Copy link
Collaborator

Fixes #300

abhinayagarwal
abhinayagarwal approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@abhinayagarwal abhinayagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good. A minor comment on renaming variables to make them smaller.

rta/src/main/java/com/gluonhq/richtextarea/RichTextArea.java Outdated Show resolved Hide resolved
rta/src/main/java/com/gluonhq/richtextarea/RichTextArea.java Outdated Show resolved Hide resolved
@jperedadnr jperedadnr merged commit e52492a into gluonhq:main Jan 17, 2024
1 check passed
@jperedadnr jperedadnr deleted the 300-decorationatcaret branch January 17, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinayagarwal abhinayagarwal abhinayagarwal approved these changes

@johanvos johanvos Awaiting requested review from johanvos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API for decoration at caret and paragraph
2 participants
@jperedadnr @abhinayagarwal