Add pasteDocument action and test #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperedadnr
changed the title
Comment on lines
745
to
+748
| int caret = getTextBuffer().getText(0, getCaretPosition()).length(); | ||
| return new Document(getTextBuffer().getText(), getTextBuffer().getDecorationModelList(), caret); | ||
| int start = selection.isDefined() ? selection.getStart() : 0; | ||
| int end = selection.isDefined() ? selection.getEnd() : getTextLength(); | ||
| return new Document(getTextBuffer().getText(start, end), getTextBuffer().getDecorationModelList(start, end), caret); |
There was a problem hiding this comment.
There are 3 calls to getTextBuffer() in this method. Wondering if we should instead create a variable.
There was a problem hiding this comment.
Not needed. In this class getTextBuffer() it is used 30+ times, without extracting variables. After all, it is just a getter from a property, with a null check.
|
I've seen that too, before this PR (as there is no decoration involved in your test). When pasting several lines somehow the width of the cell in-between two lines is changed, and defaults to 13 points or so. |
abhinayagarwal
approved these changes
May 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98
Fixes #48