Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach and detach control from viewmodel, including test #330

Merged
merged 1 commit into from
May 23, 2024
Merged

Attach and detach control from viewmodel, including test #330

merged 1 commit into from
May 23, 2024

Conversation

jperedadnr
Copy link
Collaborator

Fixes #329

abhinayagarwal
abhinayagarwal approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@abhinayagarwal abhinayagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jperedadnr jperedadnr merged commit 5ff7c3d into gluonhq:main May 23, 2024
3 checks passed
@jperedadnr jperedadnr deleted the 329-disconnectmodel branch May 23, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinayagarwal abhinayagarwal abhinayagarwal approved these changes

@johanvos johanvos Awaiting requested review from johanvos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Control properties should be unbound when viewModel performs internal actions
2 participants
@jperedadnr @abhinayagarwal