Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add MSI package for Windows to enable per-machine installs. #739

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Oliver-Loeffler
Copy link
Collaborator

@Oliver-Loeffler Oliver-Loeffler commented Oct 1, 2024

Scene Builder is published for Windows using a per-user installation MSI package, which is created by JPackage.
In certain scenarios, a per-machine install is desired.

Unfortunately, when using JPackage, one has to decide upfront between per-user or per-machine install. Having an option in the installer would require an update to JPackage or to the WXS/WXI files used by JPackage.

As an alternative approach, there could be a new Scene Builder build artifact, a MSI file for per-machine installs. Usually per-machine installs require administrative privileges on Windows whereas per-user installs don't.

The per-machine installer will use Windows default programs folder for installation (C:\Program Files\SceneBuilder) whereas the existing per-user installer will use C:\Users\<UserName>\AppData\Local\SceneBuilder\ instead.

Having 2 artifacts allows administrator to implement those into existing provosioning and deployment processes without additional use of command line flags or switches.

Per-User Installer

grafik

Per-Machine Installer

grafik

Issue

Fixes #672

Progress

@Oliver-Loeffler Oliver-Loeffler added this to the 24 milestone Oct 1, 2024
@Oliver-Loeffler Oliver-Loeffler changed the title build: Added a new msi package for Windows to enable per machine installs. fix: Add a new msi package for Windows to enable per machine installs. Oct 1, 2024
@Oliver-Loeffler Oliver-Loeffler changed the title fix: Add a new msi package for Windows to enable per machine installs. fix: Add MSI package for Windows to enable per machine installs. Oct 1, 2024
@Oliver-Loeffler Oliver-Loeffler changed the title fix: Add MSI package for Windows to enable per machine installs. fix: Add MSI package for Windows to enable per-machine installs. Oct 1, 2024
@Oliver-Loeffler Oliver-Loeffler self-assigned this Oct 1, 2024
@Oliver-Loeffler Oliver-Loeffler added packaging All related to MSI/DEB/RPM/jpackage housekeeping Addresses warnings, deprecations etc. bug Something isn't working and removed housekeeping Addresses warnings, deprecations etc. labels Oct 1, 2024
@Oliver-Loeffler Oliver-Loeffler marked this pull request as ready for review October 1, 2024 12:19
@Oliver-Loeffler Oliver-Loeffler requested review from abhinayagarwal and removed request for aalmiray October 2, 2024 16:43
@abhinayagarwal
Copy link
Collaborator

Single Package Authoring has been available for a very long time now. May be we can override WIX configuration to add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packaging All related to MSI/DEB/RPM/jpackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please provide a system wide installer
2 participants