-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add MSI package for Windows to enable per-machine installs. #739
Open
Oliver-Loeffler
wants to merge
14
commits into
gluonhq:master
Choose a base branch
from
Oliver-Loeffler:issue-672
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oliver-Loeffler
changed the title
build: Added a new msi package for Windows to enable per machine installs.
fix: Add a new msi package for Windows to enable per machine installs.
Oct 1, 2024
Oliver-Loeffler
changed the title
fix: Add a new msi package for Windows to enable per machine installs.
fix: Add MSI package for Windows to enable per machine installs.
Oct 1, 2024
Oliver-Loeffler
changed the title
fix: Add MSI package for Windows to enable per machine installs.
fix: Add MSI package for Windows to enable per-machine installs.
Oct 1, 2024
Corrected the per-user flow.
Per machine now really is setup as intended.
…er.git into issue-672
Oliver-Loeffler
added
packaging
All related to MSI/DEB/RPM/jpackage
housekeeping
Addresses warnings, deprecations etc.
bug
Something isn't working
and removed
housekeeping
Addresses warnings, deprecations etc.
labels
Oct 1, 2024
Oliver-Loeffler
requested review from
abhinayagarwal
and removed request for
aalmiray
October 2, 2024 16:43
Single Package Authoring has been available for a very long time now. May be we can override WIX configuration to add this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scene Builder is published for Windows using a per-user installation MSI package, which is created by JPackage.
In certain scenarios, a per-machine install is desired.
Unfortunately, when using JPackage, one has to decide upfront between per-user or per-machine install. Having an option in the installer would require an update to JPackage or to the WXS/WXI files used by JPackage.
As an alternative approach, there could be a new Scene Builder build artifact, a MSI file for per-machine installs. Usually per-machine installs require administrative privileges on Windows whereas per-user installs don't.
The per-machine installer will use Windows default programs folder for installation (
C:\Program Files\SceneBuilder
) whereas the existing per-user installer will useC:\Users\<UserName>\AppData\Local\SceneBuilder\
instead.Having 2 artifacts allows administrator to implement those into existing provosioning and deployment processes without additional use of command line flags or switches.
Per-User Installer
Per-Machine Installer
Issue
Fixes #672
Progress