Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value from 1 to 2 #1184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nlisker
Copy link

@nlisker nlisker commented Oct 31, 2022

Changes the value of -Dmonocle.input.touchRadius from 1 to 2.

Fixes #1183

Progress

@javateer
Copy link

javateer commented Dec 1, 2022

Do not do this.

Changing the default value from 1 to 2 imposes that change onto all developers' applications. This change comes at the cost of scrolling lists no longer moving in a smooth, fluid manner. Instead, the widgets being scrolled shift in a choppy / shakey undesirable fashion. This becoming "the norm" of an app built using GluonFX will hurt its brand.

An appropriate fix (with demonstration code provided here) proves the default value of monocle.input.touchRadius = 1 can remain, and still, the GluonFX touch/drag events work as expected across all devices, including the problematic Samsung.

Anyone that still has cause to want to increase monocle.input.touchRadius to value of 2 or greater can still do so onto their own application without burdening the entire community to override that change back to 1 in their own apps' configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change -Dmonocle.input.touchRadius value to 2
2 participants