Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Architecture, OS, Vendor and TripletProfile into enums #229

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

eugener
Copy link
Contributor

@eugener eugener commented Dec 28, 2019

This for some useful methods on enums instead of using switch statements.

eugener and others added 13 commits November 29, 2019 16:54
� Conflicts:
�	src/main/java/com/gluonhq/substrate/ProjectConfiguration.java
�	src/main/java/com/gluonhq/substrate/SubstrateDispatcher.java
�	src/main/java/com/gluonhq/substrate/model/InternalProjectConfiguration.java
�	src/main/java/com/gluonhq/substrate/target/AbstractTargetConfiguration.java
�	src/main/java/com/gluonhq/substrate/target/DarwinTargetConfiguration.java
�	src/main/java/com/gluonhq/substrate/target/IosTargetConfiguration.java
�	src/main/java/com/gluonhq/substrate/target/LinuxTargetConfiguration.java
�	src/main/java/com/gluonhq/substrate/util/FileDeps.java
@eugener
Copy link
Contributor Author

eugener commented Dec 28, 2019

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 1
           

Complexity increasing per file
==============================
- src/main/java/com/gluonhq/substrate/target/TripletProfile.java  7
- src/main/java/com/gluonhq/substrate/target/Architecture.java  1
- src/main/java/com/gluonhq/substrate/target/Vendor.java  1
- src/main/java/com/gluonhq/substrate/target/OS.java  5
         

Complexity decreasing per file
==============================
+ src/main/java/com/gluonhq/substrate/model/Triplet.java  -6
         

See the complete overview on Codacy

@@ -0,0 +1,42 @@
package com.gluonhq.substrate.target;

import com.gluonhq.substrate.Constants;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/**
* Predefined Profiles
*/
public enum TripletProfile {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enum is actually the os-vendor combination of the triplet. I don't think we can map it like that. For example, Linux on AArch64 needs a separate profile (aarch64-linux-linux)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants