Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to change font size as requested in #12 #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zjosua
Copy link
Contributor

@zjosua zjosua commented Dec 24, 2019

Description

Concisely describe what the pull request is trying to achieve. If pertinent, link to an existing issue report, or briefly explain the problem the PR is meant to solve. Feel free to attach screenshots or other media for UI-related changes.

issues/todo:

  • credit icon author: Freepik on Flaticon (License); edited by me
  • maybe check for hotkey conflicts more thoroughly (I didn't have any issues so far)
  • Anki's default font size is between 4 and 5, therefore changing back to the default font requires using the Remove formatting button.
  • Values greater than 7 default to font size 7.

Checklist:

Please replace the space inside the brackets with an x and fill out the ellipses if the following items apply:

  • I've read and understood the contribution guidelines
  • I've tested my changes against at least one of the following Anki builds:
    • Latest standard Anki 2.1 binary build [required for Anki-compatible 2.1 add-ons]
    • Latest alternative Anki 2.1 binary build
    • Running Anki 2.1 from source (commit ed8340a)
    • Latest Anki 2.0 binary build [required for Anki 2.0-compatible add-ons]
  • I've tested my changes on at least one of the following platforms:
    • Linux, version: Debian bullseye
    • Windows, version:
    • macOS, version:
  • My changes potentially affect non-desktop platforms, of which I've tested:
    • AnkiMobile, version:
    • AnkiDroid, version:
    • AnkiWeb

issues/todo:
- credit icon author
- Anki's default font size is between 4 and 5, therefore changing back
to the default font requires using the Remove formatting button.
- Values greater than 7 default to font size 7.
@glutanimate glutanimate self-requested a review November 15, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant