Cross chain single sided pools #2118
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments; update platformTokens.json with new token entries for BTC and WETH
Deploying gmx-interface with
|
| Latest commit: |
53b4df8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fe30d590.gmx-interface.pages.dev |
| Branch Preview URL: | https://fedev-3200-single-side-pools.gmx-interface.pages.dev |
Deploying gmx-interface-home with
|
| Latest commit: |
53b4df8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://76cb1a24.gmx-interface-home.pages.dev |
| Branch Preview URL: | https://fedev-3200-single-side-pools.gmx-interface-home.pages.dev |
Contributor
Author
|
@cursor review |
|
Please finish setting up background agents. Go to Cursor |
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| fs.writeFileSync(outputPath, JSON.stringify(platformTokens, null, 2) + "\n", "utf8"); | ||
|
|
||
| console.log(`\n✓ Generated platform tokens JSON at: ${outputPath}`); | ||
| console.log(`✓ Found ${Object.keys(platformTokens).length} token symbols`); |
There was a problem hiding this comment.
Summary statistics count wrong object keys
The summary statistics report incorrect values. Object.keys(platformTokens).length always returns 2 (the keys mainnets and testnets), not the number of token symbols. Additionally, line 274 counts token symbols rather than chain entries despite the log message claiming "Total chain entries". The correct count for token symbols would sum keys from both platformTokens.mainnets and platformTokens.testnets, and chain entries would require iterating one level deeper.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduces automated token config generation and broadens analytics schema.
scripts/generate-platform-tokens.tsto scan LayerZero deployments and outputsrc/config/static/platformTokens.json(groups by mainnet/testnet, normalizes addresses, derives symbols)sdk/src/types/subsquid.ts:PositionChange(orderKey,positionKey,sizeInTokens) with corresponding filters/sortsPositionVolumeInfo,SwapFeesInfo,SwapVolumeInfo,VolumeInfowith query args, orderBy, and where inputssrc/config/static/platformTokens.jsonwith additional GM/GLV entries across chainsWritten by Cursor Bugbot for commit 53b4df8. This will update automatically on new commits. Configure here.