Fix multichain FEDEV-3074 #2119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unified TechnicalGmFees type. Update fee estimation logic for deposits and withdrawals, enhancing clarity and maintainability. Introduce buildDepositTransferRequests and buildWithdrawalTransferRequests functions for improved transfer request management.
…tichain-lp-gmx-acc-fix
… unified TechnicalGmFees type. Update fee estimation logic for deposits and withdrawals, enhancing clarity and maintainability. Introduce buildDepositTransferRequests and buildWithdrawalTransferRequests functions for improved transfer request management.
…ndling and selector usage. Removed unnecessary account and marketInfo checks, streamlined conditions for order submission, and updated token data selectors for consistency. Enhanced logic for determining best GM market based on amount changes.
…, simplifying conditions for deposit creation. This enhances clarity and maintains functionality.
…d optional shouldUseSignerMethod parameter. Update related fee estimation logic to use the new function signature, enhancing flexibility in signing transactions.
Deploying gmx-interface-home with
|
| Latest commit: |
c37acac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2cb872bc.gmx-interface-home.pages.dev |
| Branch Preview URL: | https://fedev-3074-fix-multichain-tx.gmx-interface-home.pages.dev |
Deploying gmx-interface with
|
| Latest commit: |
c37acac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://136d13ea.gmx-interface.pages.dev |
| Branch Preview URL: | https://fedev-3074-fix-multichain-tx.gmx-interface.pages.dev |
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
src/components/GmSwap/GmSwapBox/GmDepositWithdrawalBox/lpTxn/useWithdrawalTransactions.tsx
Show resolved
Hide resolved
src/components/GmSwap/GmSwapBox/GmDepositWithdrawalBox/useGmSwapSubmitState.tsx
Show resolved
Hide resolved
…rawalTransactions hooks. Remove unnecessary fee checks and update conditions for execution fee calculation, improving clarity and maintainability.
…3074-fix-multichain-tx
…o fee types. Update deposit and withdrawal transaction hooks to utilize these flags for improved logic flow.
…stimateGasParameters for improved clarity and maintainability. Introduce state overrides for relayer fee token and DataStore, enhancing the handling of gas payment parameters.
…6 by 100n to avoid overflow
Contributor
Author
|
@cursor review |
midas-myth
changed the title
src/components/GmSwap/GmSwapBox/GmDepositWithdrawalBox/useDepositWithdrawalFees.tsx
Outdated
Show resolved
Hide resolved
…use getByKey for improved safety and clarity. Add check for wrapped token data existence to prevent potential errors.
divhead
reviewed
Jan 6, 2026
| } | ||
| const wrappedTokenPrice = getMidPrice(wrappedTokenData.prices); | ||
| const keeperUsd = convertToUsd(technicalFees.fees.feeTokenAmount, wrappedToken.decimals, wrappedTokenPrice)!; | ||
| logicalNetworkFeeUsd = keeperUsd * -1n; |
Contributor
There was a problem hiding this comment.
let's move it to pure function from hook
divhead
reviewed
Jan 6, 2026
| DATASTORE_SLOT_INDEXES.uintValues | ||
| ), | ||
| value: toHex(maxUint256), | ||
| value: toHex(maxUint256 / 100n, { size: 32 }), |
Contributor
Author
There was a problem hiding this comment.
moved to constant and explained
…3074-fix-multichain-tx
midas-myth
changed the title
Contributor
Author
|
@cursor review |
src/domain/synthetics/markets/technicalFees/calculateGmxAccountTechnicalFees.ts
Outdated
Show resolved
Hide resolved
src/components/GmSwap/GmSwapBox/GmDepositWithdrawalBox/lpTxn/useDepositTransactions.tsx
Show resolved
Hide resolved
divhead
previously approved these changes
Jan 6, 2026
- Updated the hook to replace second token references with long and short token amounts for improved clarity. - Adjusted the type to reflect the new token amount structure. - Modified the function to utilize the updated parameters for long and short token amounts.
divhead
previously approved these changes
Jan 6, 2026
midas-myth
changed the title
midas-myth
changed the title
…f express transaction parameters
divhead
previously approved these changes
Jan 13, 2026
…l error checks and warnings
…3074-fix-multichain-tx
midas-myth
force-pushed
the
fedev-3074-fix-multichain-tx
branch
from
74d7488 to
2841f6a
Compare
Contributor
Author
|
@cursor review |
…alView components
Contributor
Author
|
@cursor review |
divhead
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Modernizes GM/GLV multichain deposit/withdrawal flows with unified fee/transfer handling and signerless express tx builds.
TechnicalGmFees(sourceChain/gmxAccount/settlementChain) and rewires fee usage across deposit/withdrawal paths, logical fee calc, and submit-state validationbuildDepositTransferRequestsandbuildWithdrawalTransferRequestsuseMultichain*ExpressTxnParams) and market tx creators to supportemptySignature(no signer) for payload buildinguseTechnicalFeesAsyncResult) to compute execution/relay fees for all pay sources and actions, using new relay param utilitiesWritten by Cursor Bugbot for commit 7e90156. This will update automatically on new commits. Configure here.