Remove typechain FEDEV-3220 #2128

midas-myth · 2025-12-24T22:50:00Z

Note

Mass migration from ethers/typechain to viem across app, simplifying contract I/O, events, and infra.

Replace ethers contracts/utilities with viem: use publicClient.readContract, watchContractEvent, encodeFunctionData, viem constants/types, and decodeErrorResult; remove typechain-specific factories and adapt tests/utilities
Refactor RPC/WebSocket and multicall layers: use viem clients, new getWsUrl, streamlined endpoint selection, remove legacy RPC fallback switcher and delete old tracker (oldRpcTracker.ts); tidy RPC debug and AB flags
Update multichain/referrals flows: use viem clients and ISigner for signing; Stargate reads via readContract; encode tx payloads with viem; adjust OFT/LayerZero subscriptions
Synthetics/markets/orders: re-encode multicalls, simulate via viem/Tenderly, fix error parsing, and make reasonBytes a string; route/debug paths slightly reorganized
Minor: add ESLint rule, small gitignore tweaks, and miscellaneous util/test migrations (max/zero constants, parseUnits, address checks)

^{Written by Cursor Bugbot for commit f60a8aa. This will update automatically on new commits. Configure here.}

…ts and updating contract interactions to use public client methods. Clean up .gitignore by removing unnecessary entries. Adjust types for QuoteOft to allow for more flexibility.

…factories, and interfaces, to streamline the codebase and eliminate redundancy.

… multiple components. Update ESLint configuration to disable optional catch binding rule. Clean up .gitignore by removing unnecessary entries. Adjust type definitions for trade history actions and improve contract interaction methods to utilize public client for better performance.

…osit functions to utilize encodeFunctionData for improved clarity and consistency. Remove redundant contract instantiation and streamline multicall payload creation across various transaction types.

…e and eliminate redundancy across various contract interfaces.

…rom the library, replacing instances of and for improved consistency and clarity in address validation and comparison.

…or improved signer management. Update random account generation to utilize private key accounts, enhancing security and consistency. Streamline wallet interactions and enhance type definitions across various components for better clarity and maintainability.

…ace into remove-typechain

…ect. Update Vite configuration to reflect these changes.

midas-myth · 2025-12-26T12:29:42Z

src/components/TradeHistory/TradeHistoryRow/utils/shared.ts

+      args?: {
+        [key in ExtractAbiItem<
+          typeof abis.CustomErrors,
+          ContractErrorName<typeof abis.CustomErrors>
+        >["inputs"][number]["name"]]: AbiParameterToPrimitiveType<
+          Extract<
+            ExtractAbiItem<typeof abis.CustomErrors, ContractErrorName<typeof abis.CustomErrors>>["inputs"][number],
+            { name: key }
+          >,
+          "inputs"
+        >;
+      };
+    }


extract to named type

midas-myth · 2025-12-26T12:37:08Z

src/context/SyntheticsStateContext/SyntheticsStateContextProvider.tsx

-  if (paramsAccount && ethers.isAddress(paramsAccount)) {
-    checkSummedAccount = ethers.getAddress(paramsAccount);
+  if (paramsAccount && isAddress(paramsAccount)) {
+    checkSummedAccount = getAddress(paramsAccount);


passs strict false

midas-myth · 2025-12-26T12:42:11Z

src/domain/synthetics/markets/feeEstimation/estimateGlvWithdrawalPlatformTokenTransferInFees.ts

-import { signCreateWithdrawal } from "../signCreateWithdrawal";
+import { signCreateGlvWithdrawal } from "../signCreateGlvWithdrawal";
 import { CreateGlvWithdrawalParams } from "../types";
 import { stargateTransferFees } from "./stargateTransferFees";

 export async function estimateGlvWithdrawalPlatformTokenTransferInFees({
  chainId,
  srcChainId,
  marketTokenAmount,
  fullWntFee,
  params,
  secondaryOrPrimaryOutputTokenAddress: _secondaryOrPrimaryOutputTokenAddress,
  globalExpressParams,
 }: {
  chainId: SettlementChainId;
  srcChainId: SourceChainId;
  marketTokenAmount: bigint;
  fullWntFee: bigint;
  params: CreateGlvWithdrawalParams;
  secondaryOrPrimaryOutputTokenAddress: string;
  globalExpressParams: GlobalExpressParams;
 }): Promise<{
  platformTokenTransferInGasLimit: bigint;
  platformTokenTransferInNativeFee: bigint;
  platformTokenTransferInComposeGas: bigint;
  relayParamsPayload: RelayParamsPayload;
 }> {
  const settlementWrappedTokenData = globalExpressParams.tokensData[getWrappedToken(chainId).address];

  const rawRelayParamsPayload = getRawRelayerParams({
    chainId,
    gasPaymentTokenAddress: settlementWrappedTokenData.address,
    relayerFeeTokenAddress: settlementWrappedTokenData.address,
    feeParams: {
      feeToken: settlementWrappedTokenData.address,
      feeAmount: fullWntFee,
      feeSwapPath: [],
    },
    externalCalls: getEmptyExternalCallsPayload(),
    tokenPermits: [],
  });

  const relayParamsPayload: RelayParamsPayload = {
    ...rawRelayParamsPayload,
    deadline: BigInt(nowInSeconds() + DEFAULT_EXPRESS_ORDER_DEADLINE_DURATION),
  };

  const vaultAddress = getContract(chainId, "GlvVault");
  const transferRequests = getTransferRequests([
    {
      to: vaultAddress,
      token: params.addresses.glv,
      amount: marketTokenAmount,
    },
  ]);

  if (!transferRequests) {
    throw new Error("Transfer requests not found");
  }

-  const signature = await signCreateWithdrawal({
+  const signature = await signCreateGlvWithdrawal({
    chainId,


wait till fix multichain is merged

midas-myth · 2025-12-26T12:45:20Z

src/domain/synthetics/markets/signCreateGlvWithdrawal.ts

-  params: CreateWithdrawalParams;
+  params: CreateGlvWithdrawalParams;


wait till fix multichain gets merged

midas-myth · 2025-12-26T12:53:51Z

src/pages/Referrals/Referrals.tsx

  let account;
-  if (queryAccount && ethers.isAddress(queryAccount)) {
-    account = ethers.getAddress(queryAccount);
+  if (queryAccount && isAddress(queryAccount)) {


use strict false

midas-myth · 2025-12-26T12:55:17Z

src/pages/NftWallet/NftWallet.jsx

-    if (!ethers.isAddress(receiver)) {
+    if (!isAddress(receiver)) {
      return t`Invalid Receiver Address`;
    }
    if (!nftAddress || nftAddress.length === 0) {
      return t`Enter NFT Address`;
    }
-    if (!ethers.isAddress(nftAddress)) {
+    if (!isAddress(nftAddress)) {


strict false

midas-myth · 2025-12-26T12:56:42Z

src/pages/AccountTransfer/CompleteAccountTransfer/CompleteAccountTransfer.tsx

  const [, copyToClipboard] = useCopyToClipboard();
  const { sender, receiver } = useParams<{ sender: string | undefined; receiver: string | undefined }>();
-  const isSenderAndReceiverValid = ethers.isAddress(sender) && ethers.isAddress(receiver);
+  const isSenderAndReceiverValid = sender && receiver && isAddress(sender) && isAddress(receiver);


strict false

midas-myth · 2025-12-26T12:57:29Z

src/pages/AccountTransfer/BeginAccountTransfer/BeginAccountTransfer.tsx

      return t`Enter Receiver Address`;
    }
-    if (!ethers.isAddress(receiver)) {
+    if (!isAddress(receiver)) {


strict false

midas-myth · 2025-12-26T13:00:17Z

src/lib/wallets/rainbowKitConfig.ts

+  const transport = fallback([
+    ...getRpcProviders(chainId, purpose).map((provider) => http(provider.url, HTTP_TRANSPORT_OPTIONS)),
+  ]);


useless spread

midas-myth · 2025-12-26T13:02:42Z

src/lib/wallets/rainbowKitConfig.ts

+  } else if (options.withExpress) {
+    transport = getRpcTransport(chainId as AnyChainId, "express");
+  } else {
+    transport = getRpcTransport(chainId as AnyChainId, "fallback");


why fallback, should be probably default

midas-myth · 2025-12-26T13:14:40Z

src/lib/rpc/index.ts

-  throw new Error(`Unsupported websocket provider for chain id: ${chainId}`);
+  return new ethers.WebSocketProvider(getWsUrl(chainId)!, network, { staticNetwork: network });


protect from unsupported chain ids

midas-myth · 2025-12-26T13:17:02Z

@cursor review

…mponents and contexts for improved flexibility.

cursor

✅ Bugbot reviewed your changes and found no bugs!

cursor

✅ Bugbot reviewed your changes and found no bugs!

…ovider mapping and updating fallback transport type from fallback to default.

cloudflare-workers-and-pages · 2025-12-26T13:33:20Z

Deploying gmx-interface-home with Cloudflare Pages

Latest commit:	`580cbc7`
Status:	✅ Deploy successful!
Preview URL:	https://4156a026.gmx-interface-home.pages.dev
Branch Preview URL:	https://remove-typechain.gmx-interface-home.pages.dev

View logs

cloudflare-workers-and-pages · 2025-12-26T13:37:17Z

Deploying gmx-interface with Cloudflare Pages

Latest commit:	`580cbc7`
Status:	✅ Deploy successful!
Preview URL:	https://b88fe7b4.gmx-interface.pages.dev
Branch Preview URL:	https://remove-typechain.gmx-interface.pages.dev

View logs

…-typechain

…oints

…-typechain

midas-myth · 2026-01-07T17:48:35Z

@cursor review

src/context/WebsocketContext/subscribeToEvents.ts

…-typechain

…event subscription logic by removing unused source chain provider references and adjusting account type to allow null. Enhanced clarity in debug logging for source chain approval events. Updated metrics to remove unnecessary data fields.

midas-myth · 2026-01-08T15:38:54Z

@cursor review

i updates the web socket handling

cursor

✅ Bugbot reviewed your changes and found no bugs!

midas-myth · 2026-01-09T12:37:16Z

src/lib/transactions/sendWalletTransaction.ts not changed

divhead · 2026-01-09T13:26:26Z

src/context/WebsocketContext/WebsocketContextProvider.tsx

-              requiredListenerCount,
-              listenerCount,
-            },
+            data: {},


why listenners params removed?

viem is move of a black box when it comes to subscriptions, i tried but it was difficuly

divhead · 2026-01-09T13:35:11Z

src/domain/synthetics/orders/simulateExecuteTxn.tsx

+    });
+
+    blockTimestamp = blockTimestampResult.result!;
+    blockNumber = currentBlockNumberResult.result!;


why we need result**!** ? probably we should check if it's exist and throw an error?

fixed, extracted to function, reused

divhead · 2026-01-09T13:36:22Z

src/domain/synthetics/orders/simulation.ts

+      ],
+    });
+
+    blockTimestamp = blockTimestampResult.result!;


same here result**!**

fixed, extracted to function, reused

divhead · 2026-01-09T13:38:05Z

src/lib/transactions/iSigner.ts


+  static fromPrivateKeyAccount(privateKeyAccount: PrivateKeyAccount): ISigner {
+    const gmxSigner = new ISigner({ privateKeyAccount });
+    gmxSigner._address = privateKeyAccount.address;


hm, seems _address should be settled in constructor?

moved to constructor, added initialization lock promise

…handling in SyntheticsEventsProvider and useMultichainEvents to eliminate websocket dependencies. Introduce new metrics for Viem WebSocket client connections and disconnections. Refactor related code for improved clarity and performance.

…eTxn and simulateExecution functions. Introduce getBlockTimestampAndNumber utility for cleaner code and error handling. Update ISigner class to include initialization lock for address resolution.

midas-myth · 2026-01-09T16:46:48Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no bugs!

…-typechain

… for viem errors. Refactor error extraction and decoding logic for improved clarity and maintainability.

…al, enhancing error handling for missing tokens in multichain events.

midas-myth · 2026-01-15T11:18:37Z

@cursor review
especially commits on the last 3 days

cursor

✅ Bugbot reviewed your changes and found no bugs!

…-typechain

midas-myth added 9 commits December 12, 2025 18:16

Refactor multichain integration by removing unused IStargateAbi impor…

4c18696

…ts and updating contract interactions to use public client methods. Clean up .gitignore by removing unnecessary entries. Adjust types for QuoteOft to allow for more flexibility.

Remove unused Typechain files for IStargate, including common types, …

078283a

…factories, and interfaces, to streamline the codebase and eliminate redundancy.

Refactor transaction encoding in synthetic markets and multichain dep…

f83c75a

…osit functions to utilize encodeFunctionData for improved clarity and consistency. Remove redundant contract instantiation and streamline multicall payload creation across various transaction types.

Remove unused Typechain files and factories to streamline the codebas…

dac148e

…e and eliminate redundancy across various contract interfaces.

Refactor address handling across multiple components to utilize and f…

753c55a

…rom the library, replacing instances of and for improved consistency and clarity in address validation and comparison.

Merge branch 'roll-out-rpc-fallbacks' of github.com:gmx-io/gmx-interf…

65031fc

…ace into remove-typechain

Remove unused typechain types and related factory files from the proj…

f60a8aa

…ect. Update Vite configuration to reflect these changes.

midas-myth self-assigned this Dec 24, 2025

midas-myth changed the title ~~Remove typechain~~ Remove typechain FEDEV-3220 Dec 26, 2025

midas-myth commented Dec 26, 2025

View reviewed changes

Refactor address validation to use non-strict mode across multiple co…

b77d1d8

…mponents and contexts for improved flexibility.

cursor bot reviewed Dec 26, 2025

View reviewed changes

Enhance RPC transport configuration by introducing type safety for pr…

e5e17eb

…ovider mapping and updating fallback transport type from fallback to default.

midas-myth marked this pull request as ready for review December 26, 2025 14:54

midas-myth added 3 commits January 7, 2026 14:33

Merge branch 'release' of github.com:gmx-io/gmx-interface into remove…

4232eb7

…-typechain

Update subsquid URLs in indexers configuration to use production endp…

e8c8e26

…oints

Merge branch 'release' of github.com:gmx-io/gmx-interface into remove…

17ed4af

…-typechain

cursor bot reviewed Jan 7, 2026

View reviewed changes

src/context/WebsocketContext/subscribeToEvents.ts Outdated Show resolved Hide resolved

midas-myth added 2 commits January 8, 2026 15:42

Merge branch 'release' of github.com:gmx-io/gmx-interface into remove…

2c7170d

…-typechain

cursor bot reviewed Jan 8, 2026

View reviewed changes

divhead reviewed Jan 9, 2026

View reviewed changes

midas-myth added 2 commits January 9, 2026 17:05

Refactor block timestamp and block number retrieval in simulateExecut…

2ee3104

…eTxn and simulateExecution functions. Introduce getBlockTimestampAndNumber utility for cleaner code and error handling. Update ISigner class to include initialization lock for address resolution.

midas-myth requested a review from divhead January 9, 2026 16:46

cursor bot reviewed Jan 9, 2026

View reviewed changes

divhead previously approved these changes Jan 12, 2026

View reviewed changes

midas-myth added 2 commits January 14, 2026 23:38

Refactor error handling in simulateExecuteTxn and simulation functions

913e803

Merge branch 'release' of github.com:gmx-io/gmx-interface into remove…

430cb61

…-typechain

midas-myth dismissed divhead’s stale review via 430cb61 January 14, 2026 22:39

Enhance error handling in parseError and related utilities; add tests…

5064962

… for viem errors. Refactor error extraction and decoding logic for improved clarity and maintainability.

midas-myth force-pushed the remove-typechain branch from c8c1a58 to 5064962 Compare January 15, 2026 02:05

Refactor useMultichainEvents to utilize getByKey for token ID retriev…

91678db

…al, enhancing error handling for missing tokens in multichain events.

cursor bot reviewed Jan 15, 2026

View reviewed changes

midas-myth added 2 commits January 15, 2026 12:34

Merge branch 'release' of github.com:gmx-io/gmx-interface into remove…

4847e92

…-typechain

Merge branch 'release' of github.com:gmx-io/gmx-interface into remove…

580cbc7

…-typechain

		params: CreateWithdrawalParams;
		params: CreateGlvWithdrawalParams;

		throw new Error(`Unsupported websocket provider for chain id: ${chainId}`);
		return new ethers.WebSocketProvider(getWsUrl(chainId)!, network, { staticNetwork: network });

Remove typechain FEDEV-3220 #2128

Are you sure you want to change the base?

Remove typechain FEDEV-3220 #2128

Uh oh!

Conversation

midas-myth commented Dec 24, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

midas-myth commented Dec 26, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cloudflare-workers-and-pages bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying gmx-interface-home with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying gmx-interface with Cloudflare Pages

Uh oh!

midas-myth commented Jan 7, 2026

Uh oh!

Uh oh!

midas-myth commented Jan 8, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

midas-myth commented Jan 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

midas-myth commented Dec 24, 2025 •

edited by cursor bot

Loading

cloudflare-workers-and-pages bot commented Dec 26, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 26, 2025 •

edited

Loading

divhead Jan 9, 2026 •

edited

Loading