Align dispenser boat placement on ice with vanilla waterlogged behavior#359
Open
brandonhenness wants to merge 1 commit intognembon:masterfrom
Open
Align dispenser boat placement on ice with vanilla waterlogged behavior#359brandonhenness wants to merge 1 commit intognembon:masterfrom
brandonhenness wants to merge 1 commit intognembon:masterfrom
Conversation
Extend BoatDispenserBehavior logic so dispensers place boats on ice using the same placement rules as water/waterlogged blocks, including proper height offsets when ice is directly in front.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the existing
dispensersPlaceBoatsOnIcerule so that dispenser boat placement on ice follows the same logic that vanilla applies when placing boats into water or waterlogged blocks.Summary of changes
Linked issue
Fixes #358
Testing
I tested this feature extensively to ensure full parity with vanilla behavior:
Screenshot of the tests is attached below.