Open
Conversation
Mojang also ignored them
|
Could a maintainer take a look at merging / publishing this ? |
|
@Crystal0404 could you please provide a build of this PR somewhere if that's not to much trouble for you ? |
|
@debilausaure they are available at : https://github.com/gnembon/carpet-extra/actions/runs/20233803619 |
|
楽 |
|
@Crystal0404 Can I add your mods as overrides in my modpack? |
Contributor
Author
of course you can, LGPL-3.0 allows you to do this. But my suggestion is not to do this, it still has many problems now... |
|
Hey Crystal, Just out of curiosity what sort of problems were you seeing with your PR build? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually, there were no changes at all in version 1.21.11... but it’s the last version with Yarn, so it’s time to migrate :)
Other
setLenient()has been deprecated.There are still many
@NotNullannotations missing, and I haven't added them yet... I'm not sure if they need to be added.