Prevent duplicate trades in potion_master_cleric.sc#362
Open
Conversation
Never get two trades of the same potion effect and potion type Maximum trades will never be more than maximum possible unique trades
rv3r
commented
Feb 5, 2023
| loop(rand(1 + global_max_potion_trades), | ||
|
|
||
| i = _; | ||
| mapped_effects = map(effects, _ ~ '(?<=Potion of )\\w*'); |
Collaborator
Author
There was a problem hiding this comment.
Why did you take the time to map the effects instead of using them directly?
Because debugging with a list that has entries that are 12+ lines of text is painful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #325 duplicate trade issue. I haven't touched xp produced by the trades.
Never get two trades of the same potion effect and potion type. Maximum trades will never be more than maximum possible unique trades.