-
-
Notifications
You must be signed in to change notification settings - Fork 28
Update libs for Scala Native 0.5.x #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ab609ca to
6a9b24b
Compare
| // NOTE: cross build disabled for NativePlatform due to decline-effect missing on native | ||
| // lazy val exampleJq = crossProject(JVMPlatform, NativePlatform, JSPlatform) | ||
| lazy val exampleJq = crossProject(JVMPlatform, JSPlatform) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this should be a blocker? or we're good like this for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we would have it for the final release, but we can start and merge this PR without native support for the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that there's already a PR ready in Decline to re-enable the effect module: bkirwi/decline#618
Once CE has a stable release hopefully it will be merged.
cacb91e to
d20f1ff
Compare
d20f1ff to
c677a84
Compare
e6fb1d8 to
481aab1
Compare
This PR updates the project to Scala Native 0.5.8.
TODO:
0.5.x. Since it was only used forexampleJqmodule I disabled cross-build to native for now.