Make patience algorithm more stack friendly #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by the issue raised in diffson (see gnieh/diffson#63), turning the `Stacked.chain` computation into a tail recursive method makes it possible to use Patience algorithm on big arrays.
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 38.63% 38.79% +0.16%
==========================================
Files 43 43
Lines 1522 1526 +4
Branches 167 166 -1
==========================================
+ Hits 588 592 +4
Misses 934 934
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the issue raised in diffson (see gnieh/diffson#63), turning
the
Stacked.chaincomputation into a tail recursive method makes itpossible to use Patience algorithm on big arrays.