chore(otel): Open Telemetry metrics fixed and provided with demo example #3038
+257
−281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sw360cab
commented
Oct 28, 2024
sw360cab
commented
- Redefine and cleanup Open Telemetry metrics types and usage
- Rehauled demo example adding a minimal sample of RCP + Validator Node
github-actions
bot
added
📦 🌐 tendermint v2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3038 +/- ##
==========================================
+ Coverage 63.37% 63.39% +0.01%
==========================================
Files 566 566
Lines 79490 79465 -25
==========================================
- Hits 50374 50373 -1
+ Misses 25727 25702 -25
- Partials 3389 3390 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
approved these changes
Oct 30, 2024
| return res | ||
| } | ||
|
|
||
| // logQueryTelemetry logs the relevant VM query telemetry | ||
| func logQueryTelemetry(path string, isErr bool) { |
There was a problem hiding this comment.
We removed that with @zivkovicmilos because so far we find out that collecting VM low-level info are not relevant in terms of telemetry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.