fix: switch branch stmts #3043
Open
fix: switch branch stmts #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petar-dambovaliev
force-pushed
the
2973
branch
from
5f5172c
to
c5dcb0a
Compare
petar-dambovaliev
changed the title
petar-dambovaliev
requested review from
thehowl,
zivkovicmilos,
jaekwon,
moul and
ltzmaxwell
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3043 +/- ##
==========================================
- Coverage 63.37% 63.37% -0.01%
==========================================
Files 566 566
Lines 79490 79506 +16
==========================================
+ Hits 50374 50384 +10
- Misses 25727 25732 +5
- Partials 3389 3390 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ltzmaxwell
reviewed
Nov 4, 2024
| @@ -2125,8 +2130,19 @@ func preprocess1(store Store, ctx BlockNode, n Node) Node { | |||
|
|
|||
| // TRANS_LEAVE ----------------------- | |||
| case *BranchStmt: | |||
|
|
|||
There was a problem hiding this comment.
delete this line for consistency.
| @@ -2139,6 +2155,8 @@ func preprocess1(store Store, ctx BlockNode, n Node) Node { | |||
| } | |||
| } | |||
| case CONTINUE: | |||
| notAllowedFunc("continue") | |||
There was a problem hiding this comment.
should this logic be merged into findContinuableNode and findBranchLabel, seems what we need to do is to make these two funcs correct.
|
|
||
| if n.GetAttribute(ATTR_LAST_BLOCK_STMT) != true { | ||
| // no more clause after the one executed, this is not allowed | ||
| panic("fallthrough statement out of place") |
There was a problem hiding this comment.
any test targeting this?
ltzmaxwell
reviewed
Nov 4, 2024
| ATTR_LOOP_DEFINES GnoAttribute = "ATTR_LOOP_DEFINES" // []Name defined within loops. | ||
| ATTR_LOOP_USES GnoAttribute = "ATTR_LOOP_USES" // []Name loop defines actually used. | ||
| ATTR_SHIFT_RHS GnoAttribute = "ATTR_SHIFT_RHS" | ||
| ATTR_LAST_BLOCK_STMT GnoAttribute = "ATTR_LAST_BLOCK_STMT" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation for
break,continueandfallthroughto disallow invalid code.Moves existing validation from the runtime to the preprocessor.
Associated issue