feat(gnovm): fill in 3779, the gc PR #3789
Conversation
github-actions
bot
added
📦 🤖 gnovm
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
ltzmaxwell
changed the title
| // stop metric before next visit. | ||
| if bm.GCEnabled { | ||
| bm.StopGCCode() | ||
| } |
There was a problem hiding this comment.
why do we need to stop it before the next visit?
isn't it all just visits, all continuously GC?
There was a problem hiding this comment.
removed benchmark and planned for future.
| // Add object size to alloc. | ||
| size := o.GetShallowSize() | ||
| alloc.visitCount++ // count for gas calculation | ||
|
|
||
| alloc.Allocate(size) | ||
| // Stop if alloc max exceeded. | ||
| maxBytes, curBytes := alloc.Status() | ||
| if maxBytes < curBytes { |
There was a problem hiding this comment.
Can this really happen? GC usually occurs at a critical point, meaning that before this allocation, the total number of bytes hasn’t exceeded maxBytes. So during the recalculation process, the calculated result should not exceed the last crossing point, right?
gnovm/pkg/gnolang/values.go
Outdated
| type StringValue struct { | ||
| isNewBase bool // if the underlying data is new allocated or not. | ||
| Base *SliceValue | ||
| } |
There was a problem hiding this comment.
This provides a method for handling string memory reuse and reallocation
e.g..
// MAXALLOC: 100000000
package main
import "runtime"
var s = "hello world" // allocated in preprocess.
func main() {
s += "!" // underlying array re-allocated in runtime
s1 := s // another string value, underlying array stays unchanged.
runtime.GC()
println("MemStats: ", runtime.MemStats())
}
This PR is trying to complete the work outlined in #3779 .
It completes the
visitlogic and introduces benchmarking and gas consumption tracking.