-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnovm): allow multiple NaN keys in maps #3932
base: master
Are you sure you want to change the base?
Conversation
The behavior of maps with NaN no matches Go. Fixes #3867.
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
this makes a one-element map in go, but a two-element map in gno. |
The key identity was defeated by the fact that Remaining special values The above sample for +0.0 vs -0.0, once fix applied, raises another separate issue that we have in general with literal composite expressions: #3964. I will provide a test with floating point keys in the PR fixing it. |
The behavior of maps with NaN now matches Go.
Fixes #3867.