Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnovm): charge gas for type checking the Go AST statically #3974

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

odeke-em
Copy link
Contributor

Typechecking the Go abstract syntax tree incurs a huge penalty as part of the GnoVM's functionality when starting up and before running a package, hence it is only natural to also charge a cost. At first the charges shall be naive and as we expend more thought and research, shall refine what and how much to charge.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Mar 19, 2025
@Gno2D2 Gno2D2 requested a review from a team March 19, 2025 02:17
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Mar 19, 2025

🛠 PR Checks Summary

🔴 Pending initial approval by a review team member, or review from tech-staff

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: odeke-em/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🔴 Requirement not satisfied
└── 🔴 If
    ├── 🔴 Condition
    │   └── 🔴 Or
    │       ├── 🔴 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🔴 Else
        └── 🔴 And
            ├── 🟢 This label is applied to pull request: review/triage-pending
            └── 🔴 On no pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

Typechecking the Go abstract syntax tree incurs a huge penalty
as part of the GnoVM's functionality when starting up and before
running a package, hence it is only natural to also charge a
cost. At first the charges shall be naive and as we expend more
thought and research, shall refine what and how much to charge.
@odeke-em odeke-em force-pushed the gnovm-charge-gas-for-every-expression branch from 6adc70b to 1c96d70 Compare March 19, 2025 14:20
@odeke-em odeke-em marked this pull request as ready for review March 19, 2025 14:20
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Mar 19, 2025
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Mar 19, 2025
@odeke-em odeke-em force-pushed the gnovm-charge-gas-for-every-expression branch from 0d27603 to 6109a7b Compare March 19, 2025 14:25
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 87.71930% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/gotypecheck.go 89.09% 6 Missing ⚠️
gno.land/pkg/sdk/vm/keeper.go 50.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@odeke-em odeke-em force-pushed the gnovm-charge-gas-for-every-expression branch from 862bb12 to 21b669c Compare March 19, 2025 15:02
@odeke-em odeke-em force-pushed the gnovm-charge-gas-for-every-expression branch from 21b669c to 3c43764 Compare March 19, 2025 15:06
@zivkovicmilos zivkovicmilos requested review from thehowl and ltzmaxwell and removed request for a team March 19, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related review/triage-pending PRs opened by external contributors that are waiting for the 1st review
Projects
Status: No status
Status: Triage
Development

Successfully merging this pull request may close these issues.

2 participants