-
Notifications
You must be signed in to change notification settings - Fork 441
chore(gnodoc): Fetch from vm/qdoc #4934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 Pending initial approval by a review team member, or review from tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
b05b323 to
e469d51
Compare
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
6bf5830 to
1df25c2
Compare
Resolves the final feature from #522 (comment) to fetch from vm/qdoc on the remote of the package is not available locally.
Documentablestruct, add optional fielddocABCIQueryClientinterface which is also implemented byRPCClientbut only hasABCIQuery. (This will allow us to make a mock for testing.)resolveDocumentable, if the package isn't found locally, callABCIQueryin thequeryClientto query the vm/qdoc endpoint and set thedocfield inDocumentableWriteDocumentation, check if theDocumentablehasdocand use it (instead of building a newJSONDocumentation)remoteandremoteTimeout(like in gnoweb). Use these to make anRPCClientto pass toResolveDocumentablemockQueryClientand use it to test calling thequeryClient