-
Notifications
You must be signed in to change notification settings - Fork 441
feat(tm2): improve error message on invalid coins #4942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(tm2): improve error message on invalid coins #4942
Conversation
🛠 PR Checks Summary🔴 Pending initial approval by a review team member, or review from tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@MikaelVallenet, are you able to fix the CI checks? |
done ✅ |
7b1075e to
4bc057e
Compare
fix #4930
I know TM2 is a "foundational" component we avoid to change.
I met a problem with not explicit error i tried to fix it, i could fix it in the IssueCoin fn here but felt like it make more sense in tm2.
I was also thinking of improving this error message, but to keep it scoped i did not do it in this PR
This error is used why coins are not valid, but it does not explain what is a valid coin (sorted, positive amount, lowercase denom)