-
Notifications
You must be signed in to change notification settings - Fork 5
feat: multisig support #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5d4ffe7
feat: add multisig types
616d87d
fix: it's aliiiiveee
23cbcb8
feat: wallet signTransaction opts
c91c9db
chore: revert pm changes
5280d24
feat: expose helper function to work with CompactBitArray
8349e75
chore: remove chainId signTransaction option
095e9d0
chore: revert artifact
d44641b
chore: remove outdated comment
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| syntax = "proto3"; | ||
| package tm; | ||
|
|
||
| option go_package = "github.com/gnolang/gno/tm2/pkg/crypto/multisig/pb"; | ||
|
|
||
| // imports | ||
| import "google/protobuf/any.proto"; | ||
|
|
||
| // messages | ||
| message PubKeyMultisig { | ||
| uint64 k = 1 [json_name = "threshold"]; | ||
| repeated google.protobuf.Any pub_keys = 2 [json_name = "pubkeys"]; | ||
| } | ||
|
|
||
| message Multisignature { | ||
| CompactBitArray bit_array = 1; | ||
| repeated bytes sigs = 2; | ||
| } | ||
|
|
||
| message CompactBitArray { | ||
| uint32 extra_bits_stored = 1 [json_name = "extra_bits"]; // The number of extra bits in elems. | ||
| bytes elems = 2 [json_name = "bits"]; | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import { bytesToHex } from '@noble/hashes/utils'; | ||
| import { CompactBitArray } from './multisig'; | ||
|
|
||
| describe('TestMarshalCompactBitArrayAmino', () => { | ||
| const testCases = [ | ||
| { marshalledBA: `null`, hexOutput: '' }, | ||
| { marshalledBA: `null`, hexOutput: '' }, | ||
| { marshalledBA: `"_"`, hexOutput: '0801120100' }, | ||
| { marshalledBA: `"x"`, hexOutput: '0801120180' }, | ||
| { marshalledBA: `"xx___"`, hexOutput: '08051201c0' }, | ||
| { marshalledBA: `"xx______x"`, hexOutput: '08011202c080' }, | ||
| { marshalledBA: `"xx_____________x"`, hexOutput: '1202c001' }, | ||
| ]; | ||
|
|
||
| test.each(testCases)('$marshalledBA', async ({ marshalledBA, hexOutput }) => { | ||
| // Parse JSON into CompactBitArray | ||
| const jsonData = JSON.parse(marshalledBA); | ||
| const bA = CompactBitArray.fromJSON(jsonData); | ||
|
|
||
| // Marshal using Amino | ||
| const bz = CompactBitArray.encode(bA).finish(); | ||
|
|
||
| // Convert bytes to hex and compare | ||
| const actualHex = bytesToHex(bz); | ||
| expect(actualHex).toBe(hexOutput); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.