feat: add scatterplot svg library#12
Conversation
|
Hey, nice idea! 🥳 |
| @@ -0,0 +1,50 @@ | |||
| # GNOV Scatterplot | |||
|
|
|||
| The `gnov` package allows you to render a scatter plot as an SVG image. It takes a list of `(x, y)` points and draws them as circles on a 2D canvas. You can also apply optional flags to display regression lines or curves. | |||
There was a problem hiding this comment.
Gno Visual aha but i thinks we can find a better name for this ...
There was a problem hiding this comment.
If you keep the name (which I think is alright), I think it's always great to highlight what it means, so the reader can better remind of it!
There was a problem hiding this comment.
As @Davphla said; rename the H1 to the full name, GnoVisual, so that it makes sense to the reader. Then, you can chose to abbreviate it if you want. I get the point of shortening names, but you should ty naming your packages so that they're recognizable from the import path. A good name would be 'p/pierre115/scatterplot` :)
| Label string | ||
| } | ||
|
|
||
| // Scatterplot structure |
|
|
||
| `POINTS` strcuture is set with the following arguments : | ||
| ```go | ||
| X, Y float64 |
There was a problem hiding this comment.
Add the type point struct { here to make it easier to read
|
Hey, can you please reply to @Davphla's comments before resolving the conversations? |
|
@divisio74 I recommend you to add the link to the commit when replying to the comment! |
davd-gzl
left a comment
There was a problem hiding this comment.
Overall some missing details, but after it's fixed it should be good I think!
|
Also CI don't pass |
|
you can run |
leohhhn
left a comment
There was a problem hiding this comment.
Leaving some preliminary comments
| @@ -0,0 +1,50 @@ | |||
| # GNOV Scatterplot | |||
|
|
|||
| The `gnov` package allows you to render a scatter plot as an SVG image. It takes a list of `(x, y)` points and draws them as circles on a 2D canvas. You can also apply optional flags to display regression lines or curves. | |||
There was a problem hiding this comment.
As @Davphla said; rename the H1 to the full name, GnoVisual, so that it makes sense to the reader. Then, you can chose to abbreviate it if you want. I get the point of shortening names, but you should ty naming your packages so that they're recognizable from the import path. A good name would be 'p/pierre115/scatterplot` :)
leohhhn
left a comment
There was a problem hiding this comment.
can you check out a few more comments by me and @Davphla so we can go ahead with the merge?
|
|
Gno Scatterplot
New Pr for the
gnovpackage with coding style correction and newREADME.mdThe
gnovpackage allows you to render a scatter plot as an SVG image. It takes a list of(x, y)points and draws them as circles on a 2D canvas. You can also apply optional flags to display regression lines or curves.API references
POINTSstrcuture is set with the following arguments :TITLE,X_AXIS_TITLE,Y_AXIS_TITLEare strings.FlagReis aBooleanvalue:trueto enable and false by default.Maxticksis anintn used to divide the axis into n graduation marks.Widthandheightareintto personalize the size of the scatterplot.Usage
UsecaseFlags
Lineary Regression flagthat display theregression lineof the scatterplot can be actived by the booltrue.Each flag shows the
equationof the regression in the top left of the Scatterplot.Example