feat: HitTheZone#9
Conversation
Nezketsu
changed the title
|
Can you write some tests? |
|
I see you added TrustFactor, separate it in a second PR if possible! |
Yes it's a mistake i will fix it tomorrow ! |
|
Globally looks good to me, I need to try it to be sure |
leohhhn
left a comment
leohhhn
left a comment
There was a problem hiding this comment.
this is a good start, but i'm leaving some comments on things you need to change or improve. check them out below
|
Please check why the CI is red! Also, please reply to each comment I'm leaving. |
I think the problem is because the CI dont find the std package i dont know where to fix it. And sure i will reply to each comment now |
|
|
I fixed it normally i used new packages |
davd-gzl
left a comment
davd-gzl
left a comment
There was a problem hiding this comment.
Also update to include gnolang/gno#4040 new spec
You can run gno fix to do it
leohhhn
left a comment
leohhhn
left a comment
There was a problem hiding this comment.
Leaving a few more comments before we can move forward
|
Can you please reply to all comments? |
3 participants
This PR is for adding my personal realm HitTheZone i made to learn base of gno language. This realm This is a simple betting game where a random number between 1 and 100 is generated. Your goal is to select a number range and place a bet on whether the randomly drawn number will fall within that range.