fix(cycle-detection): make rule opt-in to silence false positives#192
Merged
Conversation
AST-only call-graph detection cannot distinguish bounded mutual recursion (recursive-descent decoders, depth-guarded tree walks) from a real cycle. Defaulting to SeverityError surfaced these as build-breaking errors on otherwise-correct code. Flip DefaultSeverity to SeverityOff so the rule stays silent unless a project explicitly opts in via .tlin.yaml. The engine already skips dispatch when effective severity is Off, so no engine change is required. TestRulesFireOnTestdata previously asserted cycle-detection fires on cycle0.gno under NewEngine(nil); split that case out into a new TestRulesFireOnTestdata_OptIn that enables the rule via config and asserts the same wiring invariant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AST-only call-graph detection cannot distinguish bounded mutual recursion (recursive-descent decoders, depth-guarded tree walks) from a real cycle. Defaulting to SeverityError surfaced these as build-breaking errors on otherwise-correct code.
Flip DefaultSeverity to SeverityOff so the rule stays silent unless a project explicitly opts in via .tlin.yaml. The engine already skips dispatch when effective severity is Off, so no engine change is required.
TestRulesFireOnTestdata previously asserted cycle-detection fires on cycle0.gno under NewEngine(nil); split that case out into a new TestRulesFireOnTestdata_OptIn that enables the rule via config and asserts the same wiring invariant.